Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FurnaceEvents, Expressions #7093

Open
wants to merge 30 commits into
base: dev/feature
Choose a base branch
from

Conversation

TheAbsolutionism
Copy link

Description

This PR aims to add two of of the missing furnace events, and a rewrite of old expressions plus addition of new expressions


Target Minecraft Versions: any
Requirements: none
Related Issues: none

Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first look over

src/test/skript/tests/syntaxes/expressions/ExprFurnace.sk Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
@cheeezburga cheeezburga added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 19, 2024
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this must've taken ages, good work! i can't even review it all at once :)

src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtFurnace.java Outdated Show resolved Hide resolved
sovdeeth and others added 3 commits October 15, 2024 15:35
…vents

# Conflicts:
#	src/test/skript/tests/syntaxes/expressions/ExprFurnace.sk
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should turn this into a module

@TheAbsolutionism
Copy link
Author

you should turn this into a module

I dont know if it's big enough to be turned into a module.

@sovdeeth
Copy link
Member

you should turn this into a module

I dont know if it's big enough to be turned into a module.

sure it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants